refactor(bump): eliminate similar patterns in code#1508
Merged
Lee-W merged 1 commit intocommitizen-tools:refactorsfrom Jun 8, 2025
Merged
refactor(bump): eliminate similar patterns in code#1508Lee-W merged 1 commit intocommitizen-tools:refactorsfrom
Lee-W merged 1 commit intocommitizen-tools:refactorsfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1508 +/- ##
=============================================
+ Coverage 97.87% 97.90% +0.03%
=============================================
Files 57 57
Lines 2677 2673 -4
=============================================
- Hits 2620 2617 -3
+ Misses 57 56 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
reviewed
Jun 8, 2025
commitizen/commands/bump.py
Outdated
| out.write(c.err) | ||
| for msg in (c.out, c.err): | ||
| if msg: | ||
| (out.diagnostic if self.git_output_to_stderr else out.write)(msg) |
Member
There was a problem hiding this comment.
Suggested change
| (out.diagnostic if self.git_output_to_stderr else out.write)(msg) | |
| out_func_name = "diagnostic" if self.git_output_to_stderr else "write" | |
| getattr(out, out_func_name)(msg) |
This might be a bit easier to read 🤔
Collaborator
Author
There was a problem hiding this comment.
iirc getattr does not have good type annotation. I prefer the following and still easy to read.
out_func = out.diagnostic if self.git_output_to_stderr else out.write
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
bearomorphism
force-pushed
the
refactot-cout-cerr
branch
from
b7b9066 to
b836c9e
Compare
bearomorphism
force-pushed
the
refactot-cout-cerr
branch
2 times, most recently
from
a92edf3 to
baa0224
Compare
bearomorphism
force-pushed
the
refactot-cout-cerr
branch
from
baa0224 to
99bd410
Compare
Lee-W
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist